Skip to content

fix(elements): add export for DefaultMergeStrategy - 20.1.x #16335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChronosSF merged 3 commits into from
Oct 22, 2025
Merged

fix(elements): add export for DefaultMergeStrategy - 20.1.x #16335

ChronosSF merged 3 commits into from
Oct 22, 2025

Conversation

@IMinchev64
Copy link
Contributor

@IMinchev64 IMinchev64 commented Oct 20, 2025 •
edited by skrustev
Loading

Related to #16024

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IMinchev64 IMinchev64 requested a review from skrustev October 20, 2025 14:48
@IMinchev64 IMinchev64 added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 20, 2025
@ChronosSF ChronosSF requested a review from Copilot October 21, 2025 12:31
Copilot AI reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing export for DefaultMergeStrategy in the public API of the igniteui-angular-elements package, addressing issue #16024.

  • Added import of DefaultMergeStrategy from the merge-strategy module
  • Exported DefaultMergeStrategy with the IgcDefaultMergeStrategy alias

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IMinchev64 IMinchev64 changed the title fix(elements): add export for DefaultMergeStrategy fix(elements): add export for DefaultMergeStrategy - 20.1.x Oct 21, 2025
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 21, 2025
@MayaKirova
Copy link
Contributor

MayaKirova commented Oct 21, 2025

@IMinchev64 @dkamburov @skrustev Extending the default merge strategy in react works fine now, however when building from this branch and bundling the packages for react manually it seems that merging breaks:

cell-merge-issue

Not sure if it's an issue with missing styles or maybe something else that caused issue with the size of the merged cells. Either way it needs more investigation.

@MayaKirova
Copy link
Contributor

MayaKirova commented Oct 22, 2025

Also it works as expected in 19.3.0-rc.3

@MayaKirova
Copy link
Contributor

MayaKirova commented Oct 22, 2025

Approving since issue might be in the way the wc grid package was combined (with this powershell script: https://github.com/IgniteUI/igniteui-api-analyzer/pull/108). It's possible that something in it is missing.

@MayaKirova MayaKirova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 22, 2025
@ChronosSF ChronosSF merged commit 8931bef into 20.1.x Oct 22, 2025
6 checks passed
@ChronosSF ChronosSF deleted the iminchev/default-merge-strategy-elements branch October 22, 2025 10:32
@IMinchev64 IMinchev64 mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@skrustev skrustev skrustev approved these changes

Assignees

@dkamburov dkamburov

@MayaKirova MayaKirova

Labels

grid: cell-merging version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@IMinchev64 @MayaKirova @skrustev @dkamburov @ChronosSF